🐛(pdf) preserve image aspect ratio in PDF export #1622
Conversation
Ovgodd
force-pushed
the
fix/export-pdf-images-size
branch
2 times, most recently
from
187657b to
40a5394
Compare
|
Size Change: +58 B (0%) Total Size: 4.07 MB
|
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
Definitively a great improvement !
|
|
||
| const PIXELS_PER_POINT = 0.75; | ||
| const FONT_SIZE = 16; | ||
| const MAX_WIDTH = 600; |
There was a problem hiding this comment.
Is it not duplicate with FALLBACK_SIZE ?
There was a problem hiding this comment.
Is it not duplicate with
FALLBACK_SIZE?
They are up to different things:
MAX_WIDTH = 600: Maximum width in PDF to prevent images from overflowing the page
| pngConverted = await convertSvgToPng(svgText, previewWidth); | ||
|
|
||
| // Get actual dimensions from the converted PNG | ||
| if (typeof window !== 'undefined') { | ||
| const img = document.createElement('img'); | ||
| img.src = pngConverted; | ||
| await new Promise((resolve) => { | ||
| img.onload = () => { | ||
| dimensions = { width: img.width, height: img.height }; | ||
| resolve(null); | ||
| }; | ||
| }); | ||
| } |
There was a problem hiding this comment.
I can see we have some informations in convertSvgToPng, could we do something like that maybe ?
const {
png,
width: pngWidth,
height: pngHeight,
} = await convertSvgToPng(svgText, previewWidth);
pngConverted = png;
dimensions = { width: pngWidth, height: pngHeight };There was a problem hiding this comment.
oh yes and I have to update imageODT and imageDOCS too !
| async function getImageDimensions(blob: Blob) { | ||
| if (typeof window !== 'undefined') { | ||
| const bmp = await createImageBitmap(blob); | ||
| const { width, height } = bmp; | ||
| bmp.close(); | ||
| return { width, height }; | ||
| } | ||
| } |
There was a problem hiding this comment.
I am a bit concerned about potential performance implications when lot of images and heavy images, is there maybe a less greedy way to get the size of an images?
There was a problem hiding this comment.
Oh I see, after research wdyt by switched to document.createElement('img') which should be lighter than createImageBitmap(). This matches the approach already used in imageDocx.tsx
I put it in a new fixup
Ovgodd
force-pushed
the
fix/export-pdf-images-size
branch
2 times, most recently
from
315a885 to
1c38592
Compare
Ovgodd
force-pushed
the
fix/export-pdf-images-size
branch
from
1c38592 to
ce469ac
Compare
images were distorted in PDF exports; height is now computed to fix that Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/export-pdf-images-size
branch
from
ce469ac to
2e64298
Compare
Purpose
Ensure images maintain their original aspect ratio in PDF exports, aligning behavior with DOCX/ODT exports
Proposal