♿(frontend) fix toggle panel button a11y with dynamic label and aria-… #1634
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/a11y-button-toggle-state
branch
from
68a9038 to
4bb35be
Compare
|
Size Change: +22 B (0%) Total Size: 4.07 MB
|
improves screen sr by updating label and state indication dynamically Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/a11y-button-toggle-state
branch
from
4bb35be to
0862524
Compare
AntoLC
reviewed
Nov 20, 2025
| - ♿(frontend) improve ARIA in doc grid and editor for a11y #1519 | ||
| - ♿(frontend) improve accessibility and styling of summary table #1528 | ||
| - ♿(frontend) add focus trap and enter key support to remove doc modal #1531 | ||
| - ♿(frontend) fix toggle panel button a11y with dynamic label and aria-… #1634 |
Collaborator
There was a problem hiding this comment.
Not big fan of the elliptic, you should find a more concise title, same for the title of the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix accessibility of the header panel toggle button to improve screen reader support.
issue : 1617
Proposal
aria-labeldynamically based onisPanelOpenaria-expandedto reflect the panel state