🐛(frontend) link not clickable and flickering firefox #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
issue/link-unclickable-read-mode
branch
2 times, most recently
from
60c222d to
e97a476
Compare
Move upload file logic to hooks useUploadFile. It will be more readable and easy to reuse.
Sentry highlitghted a few errors about the function "t" not being defined. Better to get it from the hook useTranslation.
AntoLC
force-pushed
the
issue/link-unclickable-read-mode
branch
from
e97a476 to
425ab97
Compare
AntoLC
force-pushed
the
issue/link-unclickable-read-mode
branch
from
425ab97 to
edabb24
Compare
The link in the read mode was not clickable anymore, it was due to a attempt to not display the cursor of anonymous users. We changes the way to do it by rendering our own cursor, when a user is anonymous we don't render the cursor. By rendering our own cursor we fixed another problem, the cursor was flickering when the user was typing at the end of the line on the firefox browser.
AntoLC
force-pushed
the
issue/link-unclickable-read-mode
branch
from
edabb24 to
b214168
Compare
PanchoutNathan
approved these changes
Nov 27, 2024
A recent update to the workbox-webpack-plugin package seems to introduce strange behavior. Better to downgrade in waiting that it is more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
At the base, this code was made to solve this issue: #384
The link in the read mode was not clickable anymore, it was due to a attempt to not display the cursor of anonymous users.
We changes the way to do it by rendering our own cursor, when a user is anonymous we don't render the cursor.
By rendering our own cursor we fixed another problem, the cursor was flickering when the user was typing at the end of the line on the firefox browser.
About the Firefox flickering issue
https://github.com/TypeCellOS/BlockNote/blob/3ef72187c6c10fbc37891d922b4ed6421474482b/packages/core/src/editor/BlockNoteExtensions.ts#L261-L262
Initially:
https://github.com/yjs/y-prosemirror/blob/df4257b499bf25b2b8e69d56cc2d8bb790f8e7ba/src/plugins/cursor-plugin.js#L39
We are investigating the purpose of it, stayed tune !
Proposal