Skip to content

Conversation

@rvveber
Copy link
Collaborator

@rvveber rvveber commented Dec 4, 2024

In order to modularize and simplify customizations to components,
the title component is encapsulated.

closes #406

@rvveber rvveber force-pushed the feature/placeholder-component-to-be-customized branch from 762f7c8 to 71a02e9 Compare December 4, 2024 10:47
@rvveber rvveber requested a review from AntoLC December 4, 2024 10:51
@rvveber rvveber marked this pull request as ready for review December 4, 2024 10:51
@rvveber rvveber marked this pull request as draft December 4, 2024 14:33
@rvveber rvveber marked this pull request as ready for review December 4, 2024 15:18
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small changes.

I don't understand how this PR can close the issue #406, could you explain ?

@rvveber
Copy link
Collaborator Author

rvveber commented Dec 5, 2024

Very small changes.

I don't understand how this PR can close the issue #406, could you explain ?

I originally created #406 due to the openDesks integration requiring a "central menu" in the header.
(The issue's title was later updated to "make toolbar customizable.")

However, since the requested change was too specific for this project and we aim to keep it generic, a more sophisticated solution would have been needed—something along the lines of: matrix-org/matrix-react-sdk-module-api.

Unfortunately, I lacked the time and experience to implement such a large-scale task, which would also require extensive testing and user documentation.

Instead, i decided to override a single component (a single file) at build time, independent of this project. To maximize compatibility with future versions of Docs, I chose to override a very simple component that was already positioned where needed, which led to encapsulating the Title to its own file.

It's a generic change for Docs, but a very helpful one for openDesk's desired override.

@rvveber rvveber force-pushed the feature/placeholder-component-to-be-customized branch from d04b744 to d4d4b02 Compare December 5, 2024 16:19
@rvveber rvveber requested a review from AntoLC December 5, 2024 16:22
@rvveber rvveber force-pushed the feature/placeholder-component-to-be-customized branch from d4d4b02 to 15be8bd Compare December 5, 2024 16:27
@rvveber rvveber force-pushed the feature/placeholder-component-to-be-customized branch from 15be8bd to 251e0dd Compare December 6, 2024 09:54
in order to modularize in the future
the title component is encapsulated.
@rvveber rvveber force-pushed the feature/placeholder-component-to-be-customized branch from 251e0dd to a7cb824 Compare December 6, 2024 09:56
@AntoLC AntoLC merged commit 131eefa into suitenumerique:main Dec 6, 2024
11 of 16 checks passed
@AntoLC AntoLC mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make toolbar / waffle configurable

2 participants