-
Couldn't load subscription status.
- Fork 416
🔨(frontend) encapsulate title component #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨(frontend) encapsulate title component #474
Conversation
762f7c8 to
71a02e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very small changes.
I don't understand how this PR can close the issue #406, could you explain ?
src/frontend/apps/impress/src/features/header/components/Title/Title.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/header/components/Title/Title.tsx
Outdated
Show resolved
Hide resolved
I originally created #406 due to the openDesks integration requiring a "central menu" in the header. However, since the requested change was too specific for this project and we aim to keep it generic, a more sophisticated solution would have been needed—something along the lines of: matrix-org/matrix-react-sdk-module-api. Unfortunately, I lacked the time and experience to implement such a large-scale task, which would also require extensive testing and user documentation. Instead, i decided to override a single component (a single file) at build time, independent of this project. To maximize compatibility with future versions of Docs, I chose to override a very simple component that was already positioned where needed, which led to encapsulating the Title to its own file. It's a generic change for Docs, but a very helpful one for openDesk's desired override. |
d04b744 to
d4d4b02
Compare
d4d4b02 to
15be8bd
Compare
15be8bd to
251e0dd
Compare
in order to modularize in the future the title component is encapsulated.
251e0dd to
a7cb824
Compare
In order to modularize and simplify customizations to components,
the title component is encapsulated.
closes #406