♻️Misc refacto #480
Merged
♻️Misc refacto #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/misc_refacto
branch
from
83eb370 to
05aded1
Compare
PanchoutNathan
approved these changes
Dec 6, 2024
Comment on lines
198
to
208
| useEffect(() => { | ||
| setHeadings(editor); | ||
|
|
||
| editor?.onEditorContentChange(() => { | ||
| setHeadings(editor); | ||
| }); | ||
|
|
||
| return () => { | ||
| resetHeadings(); | ||
| }; | ||
| }, [editor, resetHeadings, setHeadings]); |
There was a problem hiding this comment.
We already use it twice in exactly the same way, why not create a hook?
Some logs were missing or not at the good place. This commit replaces them correctly.
We will have 2 urls targeting the server, better to improve the naming to avoid confusion.
Version are not editable, we don't need to activate the collaboration provider for them. Simplify the code by removing the provider from the version.
We add a check to be sure all the services are ready before starting the e2e tests.
AntoLC
force-pushed
the
refacto/misc_refacto
branch
from
05aded1 to
31ee9ce
Compare
- We create the useHeadings hook to manage the headings of the document and staty DRY. - We use the headings store in IconOpenPanelEditor and TableContent, to avoid prop drilling. - We add a debounce on the onEditorContentChange to improve a bit the performance.
AntoLC
force-pushed
the
refacto/misc_refacto
branch
from
31ee9ce to
8508fcd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The PR #472 is quite big, we split what we can to make the review as easy as possible.
Proposal