🐛(backend) fix sanitize problem IA #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/ia-prob-sanitize
branch
2 times, most recently
from
a3d4b3b to
d87560e
Compare
Comment on lines
69
to
68
| content = response.choices[0].message.content | ||
| sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", content) | ||
| sanitized_content = re.sub(r"(?<!\\)\t", "\\\\t", sanitized_content) | ||
|
|
||
| json_response = json.loads(sanitized_content) | ||
| json_response = json.loads(response.choices[0].message.content) |
There was a problem hiding this comment.
if the fix is functional and solves the problem effectively, it seems reasonable to move forward without additional complexity.
However, we could enhance the implementation further with a try except, ignore if the sanitization fails and fallback on the json.loads
There was a problem hiding this comment.
Yes better to do that.
|
|
||
| ## Fixed | ||
|
|
||
| - 🐛(frontend) Fix hidden menu on Firefox #468 |
There was a problem hiding this comment.
this line is wrongly committed
There was a problem hiding this comment.
I think its ok, I don't want to make a commit for that.
AntoLC
force-pushed
the
fix/ia-prob-sanitize
branch
3 times, most recently
from
282ceab to
31dce82
Compare
Albert send us back a malformed IA json, the sanitize function was not able to handle it correctly. We add a try catch on it, to not use the sanitizer if the json.loads fails.
AntoLC
force-pushed
the
fix/ia-prob-sanitize
branch
from
31dce82 to
0f54d94
Compare
arnaud-robin
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Albert send us back a malformed IA json, the sanitize function was not able to handle it correctly.
Proposal
We will handle the sanitize failure with a try catch.