This repository was archived by the owner on Feb 16, 2021. It is now read-only.
Add option to set an icon on a button #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
da werkt enkel in PHP5.5 en hoger
Contributor
There was a problem hiding this comment.
we zetten trouwens ook nooit onze comments achter onze lijn, maar er boven. (maar ik zou het hier eigenlijk in de docblock van de method zetten)
Contributor
There was a problem hiding this comment.
@carakas vergeet ge die laatste comment niet te fixen?
Contributor
|
looks good to me. Eventueel wel in het framework bundle hier een voorbeeld van toevoegen? (of toch tenminste een issue ervoor aanmaken dat dat ergens in de toekomst kan gedaan worden) |
At the moment, for example in the FrameworkUserBundle icons are added by setting the icon classes to the buttons
This changes the font of the button to the icon font making it not match the rest of the application
By extending this button it is now possible to add an icon to that button
In the template:
{{ form_widget(form.example, {
'icon': 'fa fa-bug',
'label': 'Bug',
'attr':{'class': 'btn btn-large btn-default btn-block' }
}) }}
Or in the controller
$builder
->add('example', SubmitType::class, [
'label' => 'Bug',
'icon' => 'fa fa-bug',
'attr' => [
'class' => 'btn btn-large btn-default btn-block',
],
]
);
Member
|
|
WouterSioen
added a commit
that referenced
this pull request
Jan 6, 2016
Add option to set an icon on a button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, for example in the FrameworkUserBundle icons are added by setting the icon classes to the buttons
This changes the font of the button to the icon font making it not match the rest of the application
By extending this button it is now possible to add an icon to that button
In the template:
{{ form_widget(form.example, { 'icon': 'fa fa-bug', 'label': 'Bug', 'attr':{'class': 'btn btn-large btn-default btn-block' } }) }}Or in the controller