Skip to content
This repository was archived by the owner on Feb 16, 2021. It is now read-only.

Add a flash class to handle JS-generated flash messages #135

Merged
merged 3 commits into from
Oct 25, 2016
Merged

Add a flash class to handle JS-generated flash messages #135

merged 3 commits into from
Oct 25, 2016

Conversation

@StijnVrolijk
Copy link
Contributor

@StijnVrolijk StijnVrolijk commented Jun 24, 2016

Usage

  var successFlash = Flash.add('My successful flash message', 'success');
  var failedFlash = Flash.add('This flash failed', 'error');

  Flash.remove(successFlash);

WouterSioen
WouterSioen reviewed Jun 24, 2016
View reviewed changes
src/SumoCoders/FrameworkCoreBundle/Resources/assets/coffee/framework.flash.coffee Outdated
class Flash

add: (message, type) ->
alertId = Math.floor(Date.now() / 1000);
Copy link
Contributor

@WouterSioen WouterSioen Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waarom / 1000? het kan toch geen kwaad als da in milliseconde is? Integendeel: de kans op duplicate id's is kleiner!

Copy link
Contributor Author

@StijnVrolijk StijnVrolijk Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, f5b9e79

@WouterSioen
Copy link
Contributor

WouterSioen commented Jun 24, 2016

🚀

@tijsverkoyen tijsverkoyen merged commit 0c8b5be into sumocoders:master Oct 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StijnVrolijk @WouterSioen @tijsverkoyen