This repository was archived by the owner on Feb 16, 2021. It is now read-only.
Refactor flash class handling the js genereted messages #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2016 13:16
…the php created ones
When time is not defined then the flash message will be displayed till its closed or the page is refreshed
StijnVrolijk
suggested changes
Nov 17, 2016
| ' ' + message + | ||
| ' </div>' + | ||
| $('.main-header').append( | ||
| '<div class="alert alert-fixed alert-' + type + ' alert-dismissible notification" role="status" data-alert-id="' + alertId + '">' + |
Contributor
There was a problem hiding this comment.
alert-fixed is a pretty bad class name in my opinion. I'd presume it sets the alert to the fixed position
Contributor
Author
There was a problem hiding this comment.
indeed, what is is a better name in your opinion ?
Contributor
There was a problem hiding this comment.
to be honest i'd just use the .main-header .alert selector, the alert is not 'special', it's just in a special place.
tijsverkoyen
deleted the
refactor-flash-class-handling-the-js-genereted-messages
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the styling of the alert generated by
framework.flash.coffeeso it fits better with the symfony alerts.now the alerts will have a fixed position under the navigation bar.
It's also possible to define for how long the alert should be visible
->
Flash.add(message, 'success', 5000);When not defining the time, then the alert wont disappear until its closed or there is a page refresh