feat(sdk): clarify opaque JSON handling in generated request and response types#107
Merged
feat(sdk): clarify opaque JSON handling in generated request and response types#107
Conversation
…onse types Update the generator to treat opaque JSON consistently by usage: free-form request bodies and model properties now use JsonObject for ergonomic authoring, while opaque response and error payloads remain JsonDocument to preserve raw response semantics. This fixes regressions such as Apple Pay session responses, adds generator coverage for request/response/error behavior, and keeps the generated SDK surface predictable across untyped JSON schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the generator to treat opaque JSON consistently by usage: free-form request bodies and model
properties now use JsonObject for ergonomic authoring, while opaque response and error payloads remain
JsonDocument to preserve raw response semantics. This fixes regressions such as Apple Pay session
responses, adds generator coverage for request/response/error behavior, and keeps the generated SDK
surface predictable across untyped JSON schemas.