refactor(sdk): narrow deserialization error handling#89
Merged
Conversation
Only suppress JSON parsing failures in `ApiClient.TryDeserialize` instead of swallowing all exceptions. This keeps malformed API payloads non-fatal while allowing unrelated runtime errors to surface instead of being hidden behind default values. Add tests covering both malformed JSON fallback behavior and propagation of non-JSON exceptions.
This was referenced Apr 10, 2026
Merged
Merged
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only suppress JSON parsing failures in
ApiClient.TryDeserializeinstead of swallowing all exceptions. This keeps malformed API
payloads non-fatal while allowing unrelated runtime errors to
surface instead of being hidden behind default values.
Add tests covering both malformed JSON fallback behavior and
propagation of non-JSON exceptions.