add changelog and suggestions

Author: sashank27

changelog/3852.bugfix.rst

@@ -0,0 +1 @@
+Fix failing of fetching of the indexed JSOCResponses using `Fido.fetch`.

sunpy/net/fido_factory.py

@@ -14,6 +14,8 @@
 
 from parfive import Downloader, Results
 
+import warnings
+
 from sunpy.util.datatype_factory_base import BasicRegistrationFactory
 from sunpy.util.datatype_factory_base import NoMatchError
 from sunpy.util.datatype_factory_base import MultipleMatchError
@@ -25,6 +27,8 @@
 from sunpy.net import attr
 from sunpy.net import attrs as a
 
+from sunpy.util.exceptions import SunpyUserWarning
+
 __all__ = ['Fido', 'UnifiedResponse', 'UnifiedDownloaderFactory']
 
 
@@ -91,13 +95,19 @@ def _handle_record_slice(self, client_resp, record_slice):
 
         # Make sure we always have an iterable, as most of the response objects
         # expect one.
-        resp = list(client_resp[record_slice])
-
+        if isinstance(record_slice, int):
+            resp = [client_resp[record_slice]]
+        else:
+            resp = client_resp[record_slice]
         # Reconstruct a response object with the sub-indexed records.
         ret = resp_type(resp)
         # Make sure we pass the client back out again.
         ret.client = client_resp.client
 
+        warnings.warn("Downloading of sliced results is not supported. "
+                      "All the files present in the original response will be downloaded.",
+                      SunpyUserWarning)
+
         return ret
 
     def __getitem__(self, aslice):

sunpy/net/jsoc/jsoc.py

@@ -44,8 +44,8 @@ def __init__(self, table=None):
             self.requests = table[0].requests
         else:
             self.table = table
-            self.query_args = None
-            self.requests = None
+            self.query_args = table.query_args if hasattr(table, 'query_args') else None
+            self.requests = table.requests if hasattr(table, 'requests') else None
 
     def __str__(self):
         return str(self.table)
@@ -63,10 +63,13 @@ def __len__(self):
             return len(self.table)
 
     def __getitem__(self, item):
-        resp = type(self)(self.table[item])
-        resp.query_args = self.query_args
-        resp.requests = self.requests
-        return resp
+        if isinstance(item, int):
+            item = slice(item, item+1)
+        ret = type(self)(self.table[item]) 
+        ret.query_args = self.query_args
+        ret.requests = self.requests
+
+        return ret
 
     def __iter__(self):
         return (t for t in [self])

sunpy/net/tests/test_fido.py

@@ -487,9 +487,9 @@ def test_slice_jsoc():
     res = Fido.search(a.Time(tstart, tend), a.jsoc.Series('hmi.M_45s'),
                       a.jsoc.Notify('jsoc@cadair.com'))
 
-    result = Fido.fetch(res[0, 0])
-    assert isinstance(result, Results)
+    with pytest.warns(SunpyUserWarning):
+        result = Fido.fetch(res[0, 0])
+        assert isinstance(result, Results)
 
-    result = Fido.fetch(res[0, 0:2])
-    assert isinstance(result, Results)
-    
+        result = Fido.fetch(res[0, 0:2])
+        assert isinstance(result, Results)