Updated tests for resampling Generic Map and some documentation in the Sunpy/data/test. #2011

prateekiiest · 2017-02-27T13:31:44Z

@Cadair
I have updated the keys for generic map (included naxis1 and naxis2).
This PR is done to clear out the error causing in PR #2010

pep8speaks · 2017-02-27T13:31:45Z

Hello @prateekiiest! Thanks for updating the PR.

In the file sunpy/cm/cm.py, following are the PEP8 issues :

Line 114:1: E302 expected 2 blank lines, found 1
Line 184:5: E303 too many blank lines (2)
Line 184:37: E231 missing whitespace after ','

In the file sunpy/database/tests/test_database.py, following are the PEP8 issues :

Line 512:1: E302 expected 2 blank lines, found 1
Line 519:1: E302 expected 2 blank lines, found 1
Line 828:101: E501 line too long (110 > 100 characters)
Line 829:101: E501 line too long (109 > 100 characters)
Line 860:68: E251 unexpected spaces around keyword / parameter equals
Line 860:70: E251 unexpected spaces around keyword / parameter equals
Line 861:67: E251 unexpected spaces around keyword / parameter equals
Line 861:69: E251 unexpected spaces around keyword / parameter equals

In the file sunpy/net/vso/vso.py, following are the PEP8 issues :

Line 128:19: E128 continuation line under-indented for visual indent
Line 131:19: E128 continuation line under-indented for visual indent
Line 155:33: E128 continuation line under-indented for visual indent
Line 177:1: E302 expected 2 blank lines, found 1
Line 180:1: E302 expected 2 blank lines, found 1
Line 183:1: E302 expected 2 blank lines, found 1
Line 186:1: E302 expected 2 blank lines, found 1
Line 189:1: E302 expected 2 blank lines, found 1
Line 192:1: E302 expected 2 blank lines, found 1
Line 247:101: E501 line too long (108 > 100 characters)
Line 407:101: E501 line too long (111 > 100 characters)
Line 423:101: E501 line too long (140 > 100 characters)
Line 425:9: E731 do not assign a lambda expression, use a def
Line 482:30: E221 multiple spaces before operator
Line 508:101: E501 line too long (110 > 100 characters)
Line 533:101: E501 line too long (136 > 100 characters)
Line 702:25: E128 continuation line under-indented for visual indent
Line 703:13: E124 closing bracket does not match visual indentation
Line 709:55: W291 trailing whitespace
Line 710:36: W291 trailing whitespace
Line 720:54: W291 trailing whitespace
Line 751:1: E303 too many blank lines (3)
Line 834:1: E302 expected 2 blank lines, found 0
Line 841:1: E305 expected 2 blank lines after class or function definition, found 1
Line 843:1: E302 expected 2 blank lines, found 1
Line 850:1: E305 expected 2 blank lines after class or function definition, found 1
Line 860:5: E265 block comment should start with '# '

Comment last updated on March 15, 2017 at 13:34 Hours UTC

prateekiiest

Added some documentation for sunpy test database

prateekiiest · 2017-03-04T05:42:34Z

@Cadair I added some documentation related to sunpy.data.test along with issue #732 .
Pls tell me if something extra needs to be documented here, then I will send further PRs for other Sunpy.databse.test

Cadair · 2017-03-09T11:26:24Z

sunpy/net/vso/vso.py

@@ -705,13 +705,17 @@ def download(self, method, url, dw, callback, errback, *args):

    @staticmethod
    def by_provider(response):
+        """Returns a dictionary of provider corresponding 


This should not be formatted like this, it's a docstring not code.

Something like this would be correct. In general the triple quote marks """ should be on their own lines.

def by_provider(response): """ Returns a dictionary of provider corresponding to records in the response. """

prateekiiest · 2017-03-09T11:49:30Z

OK :)

prateekiiest

Updated the quotation marks.

Cadair · 2017-03-09T12:04:22Z

sunpy/map/tests/test_mapbase.py

@@ -365,7 +365,7 @@ def test_resample_metadata(generic_map, sample_method, new_dimensions):
    assert resampled_map.meta['crval2'] == generic_map.center.y.value
    for key in generic_map.meta:
        if key not in ('cdelt1', 'cdelt2', 'crpix1', 'crpix2',
-                       'crval1', 'crval2'):
+                       'crval1', 'crval2', 'naxis1', 'naxis2'):


Why is this change here? As I commented in #2010 it should not be needed.

Actually, I had changed these things in my forked repo and I didn't delete the previous changes. As a result, when I am opened a PR for this issue, all the previous changes are being shown with it.

prateekiiest

testmap , naxis1,naxis2 removed from key values

Cadair · 2017-03-15T13:24:39Z

_config.yml

@@ -0,0 +1 @@
+theme: jekyll-theme-merlot


errrr, why is this here?!

@Cadair ,Some patch problems might have occurred.

prateekiiest

updating in _config.yml in sunpy.github.io issues a file change here due to same patch work.

My bad.
Sorry @Cadair

prateekiiest · 2017-03-15T13:29:29Z

_config.yml

@@ -0,0 +1 @@
+theme: jekyll-theme-merlot


@Cadair ,Some patch problems might have occurred.

Cadair · 2017-03-15T13:52:05Z

_config.yml

@@ -0,0 +1 @@
+


This file should not be here at all.

yes, its a file in the sunpy.github.io in the website making repository.
You can close this PR.
2 or 3 PRs has been collectively addressed here
I will send separate PRs for the other related issues :)

Cadair · 2017-03-15T13:52:25Z

sunpy/net/vso/vso.py

@@ -705,13 +705,21 @@ def download(self, method, url, dw, callback, errback, *args):

    @staticmethod
    def by_provider(response):
+        """


You just opened another PR with this change in, it should only be in one place.

yes, I have sent a seperate PR for this. This PR is all jumbled up with other PRs, due to some patch mismatch. You can close this PR.

prateekiiest added 2 commits January 31, 2017 21:55

Update cm.py

6b023af

Update test_mapbase.py

2b54bc4

Merge branch 'master' into master

fb50cf1

prateekiiest mentioned this pull request Feb 27, 2017

Update dimensions metadata when resampling a map #2010

Closed

prateekiiest added 2 commits March 4, 2017 10:56

Update test_database.py

1d21697

Update test_database.py

e89603e

prateekiiest commented Mar 4, 2017

View reviewed changes

prateekiiest changed the title ~~Updated tests for resampling Generic Map.~~ Updated tests for resampling Generic Map and some documentation in the Sunpy/data/test. Mar 4, 2017

prateekiiest mentioned this pull request Mar 6, 2017

database tests depend on data/tests dir #732

Closed

Update vso.py

a7bbbbb

Cadair reviewed Mar 9, 2017

View reviewed changes

Update vso.py

66d8450

prateekiiest commented Mar 9, 2017

View reviewed changes

Cadair reviewed Mar 9, 2017

View reviewed changes

Update test_mapbase.py

291c75f

prateekiiest commented Mar 9, 2017

View reviewed changes

Set theme jekyll-theme-merlot

055d54f

Cadair reviewed Mar 15, 2017

View reviewed changes

Update _config.yml

4e46103

prateekiiest commented Mar 15, 2017

View reviewed changes

_config.yml Outdated

@@ -0,0 +1 @@

theme: jekyll-theme-merlot

Copy link

Contributor Author

prateekiiest Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cadair ,Some patch problems might have occurred.

Cadair reviewed Mar 15, 2017

View reviewed changes

Cadair closed this Mar 15, 2017

Uh oh!

Updated tests for resampling Generic Map and some documentation in the Sunpy/data/test. #2011

Updated tests for resampling Generic Map and some documentation in the Sunpy/data/test. #2011

Uh oh!

Conversation

prateekiiest commented Feb 27, 2017

Uh oh!

pep8speaks commented Feb 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated on March 15, 2017 at 13:34 Hours UTC

Uh oh!

prateekiiest left a comment

Choose a reason for hiding this comment

Uh oh!

prateekiiest commented Mar 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prateekiiest commented Mar 9, 2017

Uh oh!

prateekiiest left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prateekiiest left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prateekiiest left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pep8speaks commented Feb 27, 2017 •

edited

Loading

prateekiiest left a comment •

edited

Loading