-
-
Notifications
You must be signed in to change notification settings - Fork 617
Updated tests for resampling Generic Map and some documentation in the Sunpy/data/test. #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6b023af
2b54bc4
fb50cf1
1d21697
e89603e
a7bbbbb
66d8450
291c75f
055d54f
4e46103
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -705,13 +705,21 @@ def download(self, method, url, dw, callback, errback, *args): | |
|
||
@staticmethod | ||
def by_provider(response): | ||
""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You just opened another PR with this change in, it should only be in one place. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I have sent a seperate PR for this. This PR is all jumbled up with other PRs, due to some patch mismatch. You can close this PR. |
||
Returns a dictionary of provider corresponding | ||
to records in the response. | ||
""" | ||
map_ = defaultdict(list) | ||
for record in response: | ||
map_[record.provider].append(record) | ||
return map_ | ||
|
||
@staticmethod | ||
def by_fileid(response): | ||
""" | ||
Returns a dictionary of fileids corresponding | ||
to records in the response. | ||
""" | ||
return dict( | ||
(record.fileid, record) for record in response | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be here at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, its a file in the sunpy.github.io in the website making repository.
You can close this PR.
2 or 3 PRs has been collectively addressed here
I will send separate PRs for the other related issues :)