Skip to content
This repository was archived by the owner on Oct 23, 2025. It is now read-only.

Conversation

@sergejcodes
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

Previous behavior: TypeScript shows an error if the additionalData prop is not explicitly set on the Svelte Auth component.

Since additionalData is defined as optional in shared/src/types.ts it makes sense to also make it optional for the Svelte Auth component.

error

What is the new behavior?

The additionalData prop for the Svelte Auth component is now optional and doesn't need to be explicitly set. This prevents a scenario like this in TypeScript:

<script lang="ts">
  import { Auth } from '@supabase/auth-ui-svelte'
</script>

<Auth additionalData={undefined} />

@Blackwidow-sudo
Copy link

Blackwidow-sudo commented Sep 13, 2023

Good to see that there is already a PR.
I was following https://supabase.com/docs/guides/getting-started/tutorials/with-sveltekit#set-up-a-login-page and this error was annoying.

@silentworks
Copy link
Contributor

Thank you for this PR.

@silentworks silentworks merged commit 819666d into supabase-community:main Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants