Skip to content

Conversation

@ky1ejs
Copy link
Contributor

@ky1ejs ky1ejs commented Jun 11, 2022

I'd imagine it to be fairly common that when a user of gotrue-swift wants to complete the Partner sign in process and start a session, they don't care about the Session that is created.

@grdsdev
Copy link

grdsdev commented Jun 11, 2022

Is that the only place you think is good to have the @discardableResult?

@grdsdev grdsdev merged commit 4e22c94 into supabase-community:main Jun 13, 2022
@ky1ejs
Copy link
Contributor Author

ky1ejs commented Jun 13, 2022

Hey @GRSouza, I think most of the sign in functions could use this change. I'm happy to add those.

@ky1ejs ky1ejs deleted the session-start-discardable branch June 13, 2022 09:16
@grdsdev
Copy link

grdsdev commented Jun 13, 2022

@ky1ejs I've added it in a couple more places here (#26) and I just bump a new release https://github.com/supabase-community/gotrue-swift/releases/tag/0.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants