fix: change handling (#167)

* lets get into the mess...

* woooorks now and its much simpler

* fix: minor fixes

* fix: lint --fix

* format

* format

* pssssssht

* fixes

Author: psteinroe

crates/pg_analyse/src/filter.rs

@@ -42,7 +42,7 @@ impl<'analysis> AnalysisFilter<'analysis> {
     /// Return `true` if the group `G` matches this filter
     pub fn match_group<G: RuleGroup>(&self) -> bool {
         self.match_category::<G::Category>()
-            && self.enabled_rules.map_or(true, |enabled_rules| {
+            && self.enabled_rules.is_none_or(|enabled_rules| {
                 enabled_rules.iter().any(|filter| filter.match_group::<G>())
             })
             && !self
@@ -54,7 +54,7 @@ impl<'analysis> AnalysisFilter<'analysis> {
     /// Return `true` if the rule `R` matches this filter
     pub fn match_rule<R: Rule>(&self) -> bool {
         self.match_category::<<R::Group as RuleGroup>::Category>()
-            && self.enabled_rules.map_or(true, |enabled_rules| {
+            && self.enabled_rules.is_none_or(|enabled_rules| {
                 enabled_rules.iter().any(|filter| filter.match_rule::<R>())
             })
             && !self
@@ -94,13 +94,13 @@ impl<'a> RuleFilter<'a> {
     }
 }
 
-impl<'a> Debug for RuleFilter<'a> {
+impl Debug for RuleFilter<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         Display::fmt(self, f)
     }
 }
 
-impl<'a> Display for RuleFilter<'a> {
+impl Display for RuleFilter<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         match self {
             RuleFilter::Group(group) => {
@@ -113,7 +113,7 @@ impl<'a> Display for RuleFilter<'a> {
     }
 }
 
-impl<'a> pg_console::fmt::Display for RuleFilter<'a> {
+impl pg_console::fmt::Display for RuleFilter<'_> {
     fn fmt(&self, fmt: &mut pg_console::fmt::Formatter) -> std::io::Result<()> {
         match self {
             RuleFilter::Group(group) => {

crates/pg_cli/src/commands/daemon.rs

@@ -180,7 +180,7 @@ pub(crate) fn read_most_recent_log_file(
 
     let most_recent = fs::read_dir(biome_log_path)?
         .flatten()
-        .filter(|file| file.file_type().map_or(false, |ty| ty.is_file()))
+        .filter(|file| file.file_type().is_ok_and(|ty| ty.is_file()))
         .filter_map(|file| {
             match file
                 .file_name()

crates/pg_cli/src/commands/mod.rs

@@ -230,7 +230,7 @@ impl PgLspCommand {
 
     pub fn is_verbose(&self) -> bool {
         self.cli_options()
-            .map_or(false, |cli_options| cli_options.verbose)
+            .is_some_and(|cli_options| cli_options.verbose)
     }
 
     pub fn log_level(&self) -> LoggingLevel {

crates/pg_cli/src/execute/traverse.rs

@@ -413,7 +413,7 @@ pub(crate) struct TraversalOptions<'ctx, 'app> {
     pub(crate) evaluated_paths: RwLock<BTreeSet<PgLspPath>>,
 }
 
-impl<'ctx, 'app> TraversalOptions<'ctx, 'app> {
+impl TraversalOptions<'_, '_> {
     pub(crate) fn increment_changed(&self, path: &PgLspPath) {
         self.changed.fetch_add(1, Ordering::Relaxed);
         self.evaluated_paths
@@ -441,7 +441,7 @@ impl<'ctx, 'app> TraversalOptions<'ctx, 'app> {
     }
 }
 
-impl<'ctx, 'app> TraversalContext for TraversalOptions<'ctx, 'app> {
+impl TraversalContext for TraversalOptions<'_, '_> {
     fn interner(&self) -> &PathInterner {
         &self.interner
     }

crates/pg_cli/src/reporter/github.rs

@@ -16,7 +16,7 @@ impl Reporter for GithubReporter {
 }
 pub(crate) struct GithubReporterVisitor<'a>(pub(crate) &'a mut dyn Console);
 
-impl<'a> ReporterVisitor for GithubReporterVisitor<'a> {
+impl ReporterVisitor for GithubReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         _execution: &Execution,

crates/pg_cli/src/reporter/gitlab.rs

@@ -57,7 +57,7 @@ impl<'a> GitLabReporterVisitor<'a> {
     }
 }
 
-impl<'a> ReporterVisitor for GitLabReporterVisitor<'a> {
+impl ReporterVisitor for GitLabReporterVisitor<'_> {
     fn report_summary(&mut self, _: &Execution, _: TraversalSummary) -> std::io::Result<()> {
         Ok(())
     }
@@ -80,7 +80,7 @@ struct GitLabDiagnostics<'a>(
     Option<&'a Path>,
 );
 
-impl<'a> GitLabDiagnostics<'a> {
+impl GitLabDiagnostics<'_> {
     fn attempt_to_relativize(&self, subject: &str) -> Option<PathBuf> {
         let Ok(resolved) = Path::new(subject).absolutize() else {
             return None;
@@ -116,7 +116,7 @@ impl<'a> GitLabDiagnostics<'a> {
     }
 }
 
-impl<'a> Display for GitLabDiagnostics<'a> {
+impl Display for GitLabDiagnostics<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> std::io::Result<()> {
         let mut hasher = self.1.write().unwrap();
         let gitlab_diagnostics: Vec<_> = self

crates/pg_cli/src/reporter/junit.rs

@@ -24,7 +24,7 @@ struct JunitDiagnostic<'a> {
     diagnostic: &'a Error,
 }
 
-impl<'a> Display for JunitDiagnostic<'a> {
+impl Display for JunitDiagnostic<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         self.diagnostic.description(f)
     }
@@ -39,7 +39,7 @@ impl<'a> JunitReporterVisitor<'a> {
     }
 }
 
-impl<'a> ReporterVisitor for JunitReporterVisitor<'a> {
+impl ReporterVisitor for JunitReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         _execution: &Execution,

crates/pg_cli/src/reporter/terminal.rs

@@ -53,7 +53,7 @@ struct FixedPathsDiagnostic {
 
 pub(crate) struct ConsoleReporterVisitor<'a>(pub(crate) &'a mut dyn Console);
 
-impl<'a> ReporterVisitor for ConsoleReporterVisitor<'a> {
+impl ReporterVisitor for ConsoleReporterVisitor<'_> {
     fn report_summary(
         &mut self,
         execution: &Execution,
@@ -132,7 +132,7 @@ impl fmt::Display for Files {
 
 struct SummaryDetail<'a>(pub(crate) &'a TraversalMode, usize);
 
-impl<'a> fmt::Display for SummaryDetail<'a> {
+impl fmt::Display for SummaryDetail<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         if self.1 > 0 {
             fmt.write_markup(markup! {
@@ -147,7 +147,7 @@ impl<'a> fmt::Display for SummaryDetail<'a> {
 }
 struct SummaryTotal<'a>(&'a TraversalMode, usize, &'a Duration);
 
-impl<'a> fmt::Display for SummaryTotal<'a> {
+impl fmt::Display for SummaryTotal<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         let files = Files(self.1);
         match self.0 {
@@ -165,7 +165,7 @@ pub(crate) struct ConsoleTraversalSummary<'a>(
     pub(crate) &'a TraversalMode,
     pub(crate) &'a TraversalSummary,
 );
-impl<'a> fmt::Display for ConsoleTraversalSummary<'a> {
+impl fmt::Display for ConsoleTraversalSummary<'_> {
     fn fmt(&self, fmt: &mut Formatter) -> io::Result<()> {
         let summary = SummaryTotal(self.0, self.1.changed + self.1.unchanged, &self.1.duration);
         let detail = SummaryDetail(self.0, self.1.changed);

crates/pg_completions/Cargo.toml

@@ -16,6 +16,7 @@ async-std = "1.12.0"
 
 text-size.workspace = true
 
+
 pg_schema_cache.workspace       = true
 pg_treesitter_queries.workspace = true
 serde                           = { workspace = true, features = ["derive"] }

crates/pg_completions/src/relevance.rs

@@ -7,7 +7,7 @@ pub(crate) enum CompletionRelevanceData<'a> {
     Column(&'a pg_schema_cache::Column),
 }
 
-impl<'a> CompletionRelevanceData<'a> {
+impl CompletionRelevanceData<'_> {
     pub fn get_score(self, ctx: &CompletionContext) -> i32 {
         CompletionRelevance::from(self).into_score(ctx)
     }
@@ -28,7 +28,7 @@ pub(crate) struct CompletionRelevance<'a> {
     data: CompletionRelevanceData<'a>,
 }
 
-impl<'a> CompletionRelevance<'a> {
+impl CompletionRelevance<'_> {
     pub fn into_score(mut self, ctx: &CompletionContext) -> i32 {
         self.check_matches_schema(ctx);
         self.check_matches_query_input(ctx);