Skip to content

Conversation

@psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Feb 11, 2025

renames the cli to pglt. also updated the release action. please let me know if i missed anything!

@psteinroe psteinroe changed the title chore: rename cli to pglt chore(pglt_cli): rename binary to pglt Feb 11, 2025
Copy link
Collaborator

@juleswritescode juleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed:

  • the workflow name
  • the pg_cli in the build step

💩 But it's tricky because it's sometimes pgcli and sometimes pg_cli. Feel free to align that 👍

Have you tried running cargo build -p pglt ? I'm not sure whether cargo will look for the crate name (pglt_cli) or the binary name (pglt)

@psteinroe
Copy link
Collaborator Author

You missed:

  • the workflow name
  • the pg_cli in the build step

💩 But it's tricky because it's sometimes pgcli and sometimes pg_cli. Feel free to align that 👍

Have you tried running cargo build -p pglt ? I'm not sure whether cargo will look for the crate name (pglt_cli) or the binary name (pglt)

fixed! tested it and it looks for the name of the package, so pglt_cli works, pglt doesnt.

Copy link
Collaborator

@juleswritescode juleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the binary in the **/release folder will be named after the package, but the rest LGTM :)

@psteinroe psteinroe merged commit 0a6a0b2 into main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants