fix: with ordinality #237
Merged
fix: with ordinality #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Mar 14, 2025
| } | ||
| } | ||
|
|
||
| /// Look ahead to the next relevant token *after the next token* |
Collaborator
There was a problem hiding this comment.
Der Kommentar innerhalb der ** ist n bisschen confusing, es ist zwar under the hood next_pos + 1 aber für clients der API im Prinzip current + 1, oder? So liest es sich unten jedenfalls bei dem Ordinality check
Collaborator
Author
There was a problem hiding this comment.
yeah it's hard to grasp because if you call peek(), the look ahead will basically return the next after peek 😅 what would you suggest as a comment?
Collaborator
There was a problem hiding this comment.
vllt. einfach /// Look ahead to the next relevant token, fühlt sich für mich verständlich an…
.peek() könnte auch current() sein glaube ich?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.