Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

httpx requests fail if the url includes the query params, this was working in version 0.27.2 of httpx.

What is the new behavior?

The library no uses query params for all httpx requests

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Jan 24, 2025

Pull Request Test Coverage Report for Build 12954495117

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 60.3%

Totals Coverage Status
Change from base Build 12950004767: 0.04%
Covered Lines: 1367
Relevant Lines: 2267

💛 - Coveralls

@silentworks silentworks requested a review from grdsdev January 24, 2025 17:30
@silentworks silentworks merged commit a7a9cea into main Jan 24, 2025
9 checks passed
@silentworks silentworks deleted the silentworks/fix-httpx-issue branch January 24, 2025 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exchange_code_for_session() breaks with "unsupported_grant_type" error in 2.11.0

3 participants