Skip to content

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Feb 24, 2024

What kind of change does this PR introduce?

Bug fix #1965 (comment)

What is the new behavior?

Fixes regression introduced by previous refactoring.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner February 24, 2024 05:48
@coveralls
Copy link

coveralls commented Feb 24, 2024

Pull Request Test Coverage Report for Build 8043495358

Details

  • -4 of 17 (76.47%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.842%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/gen.go 0 2 0.0%
internal/gen/types/typescript/typescript.go 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
cmd/gen.go 1 39.13%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8017260954: -0.02%
Covered Lines: 6189
Relevant Lines: 10518

💛 - Coveralls

@sweatybridge sweatybridge changed the title fix: respect sslmode flag when generating types fix: check for sslmode explicitly when generating types Feb 26, 2024
@sweatybridge sweatybridge merged commit 99b3973 into main Feb 26, 2024
@sweatybridge sweatybridge deleted the fix-gen branch February 26, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants