Skip to content

Conversation

avallete
Copy link
Member

What kind of change does this PR introduce?

  • Ensure db reset command work properly on postgres v14

The root cause is that while in pg15+ DATABASE DROP FORCE kill all connections, it's not the case for pg14. Requiring to manually disconnect all connections before performing the reset.

Additional context

Closes #2903

@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 12005516982

Details

  • 29 of 31 (93.55%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 59.57%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/reset/reset.go 19 21 90.48%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
internal/utils/misc.go 6 71.3%
Totals Coverage Status
Change from base Build 12004204692: 0.02%
Covered Lines: 6396
Relevant Lines: 10737

💛 - Coveralls

@sweatybridge sweatybridge force-pushed the fix/db-reset-postgres-14 branch from 7c1f438 to 2eddca0 Compare November 25, 2024 07:49
@sweatybridge sweatybridge merged commit b9e89fc into develop Nov 25, 2024
13 checks passed
@sweatybridge sweatybridge deleted the fix/db-reset-postgres-14 branch November 25, 2024 07:56
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Supabase db reset fails with ERROR: database "_supabase" is used by an active logical replication slot (SQLSTATE 55006)
3 participants