Skip to content

Conversation

singh-inder
Copy link
Contributor

@singh-inder singh-inder commented Oct 11, 2025

What kind of change does this PR introduce?

Bug fix #4290

What is the new behavior?

Correctly split paths on windows. Didn't use ToDockerPath as it uses filepath.ToSlash internally

image

@singh-inder singh-inder requested a review from a team as a code owner October 11, 2025 19:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18433970309

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/deploy/bundle.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 18403671426: -0.03%
Covered Lines: 6409
Relevant Lines: 11723

💛 - Coveralls

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting and fixing this bug.

@sweatybridge sweatybridge merged commit d916a7a into supabase:develop Oct 12, 2025
13 of 14 checks passed
@singh-inder singh-inder deleted the patch-1 branch October 12, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redundant bind mounts for edge_runtime container on windows

3 participants