Skip to content

Conversation

kbsali
Copy link

@kbsali kbsali commented Nov 29, 2022

What kind of change does this PR introduce?

docs update

What is the current behavior?

When dumping an entire project, the SQL sometimes has tabs instead of 2 spaces (which seems the default)

What is the new behavior?

Additional context

@kbsali kbsali requested a review from a team as a code owner November 29, 2022 09:38
J0 pushed a commit to supabase/auth that referenced this pull request Dec 2, 2022
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3572813994

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 390 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-2.8%) to 54.923%

Files with Coverage Reduction New Missed Lines %
internal/db/branch/switch_/switch_.go 1 96.61%
internal/db/diff/migra.go 2 98.81%
internal/utils/docker.go 2 66.79%
cmd/migration.go 3 64.71%
internal/db/reset/reset.go 6 84.17%
cmd/projects.go 8 18.56%
internal/link/link.go 11 28.57%
internal/db/start/start.go 13 64.62%
cmd/link.go 14 25.0%
internal/db/lint/lint.go 20 78.79%
Totals Coverage Status
Change from base Build 3612839365: -2.8%
Covered Lines: 3057
Relevant Lines: 5566

💛 - Coveralls

@sweatybridge
Copy link
Contributor

sweatybridge commented Dec 9, 2022

When dumping an entire project, the SQL sometimes has tabs

@kbsali are you referring to running pg_dump on your local dev database? If so, that is out of scope for CLI. What we do support is dumping remote project with db remote commit.

That said, we are looking into generating these initial schemas in a fully automated way. So our preference is to fix the schemas in the respective services upstream. In this case, it is supabase/auth#843.

sweatybridge added a commit to supabase/storage that referenced this pull request Dec 9, 2022
@kbsali
Copy link
Author

kbsali commented Dec 9, 2022

ok, perfect. I wasn't sure how these sql files were generated.
That being said, there are more pieces of SQL with "wrong" indent types like storage.extension... where is that coming from ? (not Gotrue as far as I can see)

@sweatybridge
Copy link
Contributor

@kbsali kbsali closed this Dec 21, 2022
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
cemalkilic pushed a commit to supabase/auth that referenced this pull request Aug 7, 2025
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
issuedat pushed a commit to supabase/auth that referenced this pull request Sep 30, 2025
## What kind of change does this PR introduce?

related supabase/cli#648

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants