Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2023

What kind of change does this PR introduce?

Fixes #825

What is the current behavior?

The locale of the Postgres database is inherited from the host system.

What is the new behavior?

The locale of the Postgres database matches that of Supabase cloud.

Additional context

None.

@ghost ghost self-requested a review as a code owner February 1, 2023 21:10
@ghost
Copy link
Author

ghost commented Feb 1, 2023

I wonder if other containers are affected by this as well. It would be nice to get as close as possible to a production environment, in development.

Will there be a problem if pgrest or gotrue has a different LANG/LC_ALL? I don't know...

@ghost ghost changed the title Use db locale as the Supabase cloud in local development. Match db locale of Supabase cloud in local development. Feb 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4068735356

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 61.984%

Totals Coverage Status
Change from base Build 4062672907: 0.007%
Covered Lines: 3618
Relevant Lines: 5837

💛 - Coveralls

@ghost ghost changed the title Match db locale of Supabase cloud in local development. fix: match db locale of Supabase cloud in local development Feb 1, 2023
Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix! The other services should just follow the locale used by the database so I think this is fine for now.

In the future, we can look into a way to read the locale from hosted project.

@sweatybridge sweatybridge merged commit c4131f7 into supabase:main Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

🎉 This PR is included in version 1.36.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost deleted the local-match-cloud-locale branch February 2, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local environment uses en_US.UTF-8 locale, cloud uses C.UTF-8
2 participants