Skip to content

feat: removes harded coded value for jwt secret, service role key, and anon key #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 21, 2023
Merged

feat: removes harded coded value for jwt secret, service role key, and anon key #938

merged 9 commits into from
Mar 21, 2023

Conversation

ryankazokas
Copy link
Contributor

@ryankazokas ryankazokas commented Mar 17, 2023 •
edited
Loading

Pulls values from a .env file similar to how docker works. Otherwise defaults to values that are hardcoded as to not introduce any breaking changes.

I used a .env file took example from the docker configuration however if you think it suites it better to use the config.toml i can update to reflect that.

@ryankazokas ryankazokas requested a review from a team as a code owner March 17, 2023 17:55
@ryankazokas ryankazokas mentioned this pull request Mar 17, 2023
Closed
sweatybridge
sweatybridge requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@sweatybridge sweatybridge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Just a few minor suggestions. Let me know if you have time to make them

@coveralls
Copy link

coveralls commented Mar 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4476643223

  • 29 of 46 (63.04%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 62.608%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/serve/serve.go 4 6 66.67%
internal/utils/config.go 11 15 73.33%
cmd/root.go 0 11 0.0%
Totals Coverage Status
Change from base Build 4464813608: 0.006%
Covered Lines: 3826
Relevant Lines: 6111
💛 - Coveralls

@sweatybridge sweatybridge changed the title Removes harded coded value for jwt secret, service role key, and anon key feat: removes harded coded value for jwt secret, service role key, and anon key Mar 21, 2023
@sweatybridge sweatybridge merged commit b4a18ed into supabase:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryankazokas @coveralls @sweatybridge