fix: runtime created with the old eszip cannot reference static files properly in some cases #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properly in some cases
laktek
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
All scripts initialized in the runtime created by old eszip were specified based on the alternative path reported by
maybe_entrypoint, not the sanitized virtual path.These paths can be referenced via import.meta.url, and trying to use this variable to reference specific static files may cause problems.
Because the static files lookup table pointing to the actual specifier of the static file in eszip was also mapped based on sanitized virtual paths, it could not recognize the alternative paths.
This PR adds mapping for alternative paths to the static files lookup table, enabling static files to be referenced properly even in old eszip.