-
-
Notifications
You must be signed in to change notification settings - Fork 174
fix: handle postgrest special characters in filters #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 though I'd wait for steve's response on properly quoting "
itself
Something I've noticed is that the Lines 65 to 68 in e5f5dfa
Lines 70 to 73 in e5f5dfa
Lines 100 to 103 in e5f5dfa
|
Gotcha, thanks Steve! |
Co-authored-by: Steve Chavez <stevechavezast@gmail.com>
Should be good now @inian, feel free to merge 👍 |
1866016
to
5c36f1d
Compare
Thanks Bobbie and Steve! |
🎉 This PR is included in version 0.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #164
This only quotes values and not column names. Previous bugs were due to quoting column names.
I also add in a check to only quote the value if the filter value contains a postgrest special character.