This repository was archived by the owner on Aug 21, 2025. It is now read-only.
fix: send correct payload to channel on reconnect #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidtuladhar
changed the title
|
LGTM |
grdsdev
approved these changes
Jan 22, 2025
Pull Request Test Coverage Report for Build 12917870865Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I think it should fix #258
What is the current behavior?
When
auto_reconnectisTrue, the channel is attempted to joined but it uses defaul payload which is empty. Instead it should use the existing payload that was originally used when the channel was first joined.