fix: pass params to httpx request instead of encoding it in url

Author: o-santi

src/functions/src/supabase_functions/_async/functions_client.py

@@ -1,8 +1,7 @@
 from typing import Any, Dict, Literal, Optional, Union
-from urllib.parse import urlencode
 from warnings import warn
 
-from httpx import AsyncClient, HTTPError, Response
+from httpx import AsyncClient, HTTPError, Response, QueryParams
 
 from ..errors import FunctionsHttpError, FunctionsRelayError
 from ..utils import (
@@ -74,11 +73,16 @@ async def _request(
         url: str,
         headers: Optional[Dict[str, str]] = None,
         json: Optional[Dict[Any, Any]] = None,
+        params: Optional[QueryParams] = None,
     ) -> Response:
         response = (
-            await self._client.request(method, url, data=json, headers=headers)
+            await self._client.request(
+                method, url, data=json, headers=headers, params=params
+            )
             if isinstance(json, str)
-            else await self._client.request(method, url, json=json, headers=headers)
+            else await self._client.request(
+                method, url, json=json, headers=headers, params=params
+            )
         )
         try:
             response.raise_for_status()
@@ -122,6 +126,7 @@ async def invoke(
         if not is_valid_str_arg(function_name):
             raise ValueError("function_name must a valid string value.")
         headers = self.headers
+        params = QueryParams()
         body = None
         response_type = "text/plain"
         url = f"{self.url}/{function_name}"
@@ -139,15 +144,17 @@ async def invoke(
                 if region.value != "any":
                     headers["x-region"] = region.value
                     # Add region as query parameter
-                    url = f"{url}?{urlencode({'forceFunctionRegion': region.value})}"
+                    params = params.set("forceFunctionRegion", region.value)
 
             body = invoke_options.get("body")
             if isinstance(body, str):
                 headers["Content-Type"] = "text/plain"
             elif isinstance(body, dict):
                 headers["Content-Type"] = "application/json"
 
-        response = await self._request("POST", url, headers=headers, json=body)
+        response = await self._request(
+            "POST", url, headers=headers, json=body, params=params
+        )
         is_relay_error = response.headers.get("x-relay-header")
 
         if is_relay_error and is_relay_error == "true":

src/functions/src/supabase_functions/_sync/functions_client.py

@@ -1,8 +1,7 @@
 from typing import Any, Dict, Literal, Optional, Union
-from urllib.parse import urlencode
 from warnings import warn
 
-from httpx import Client, HTTPError, Response
+from httpx import Client, HTTPError, Response, QueryParams
 
 from ..errors import FunctionsHttpError, FunctionsRelayError
 from ..utils import (
@@ -74,11 +73,14 @@ def _request(
         url: str,
         headers: Optional[Dict[str, str]] = None,
         json: Optional[Dict[Any, Any]] = None,
+        params: Optional[QueryParams] = None,
     ) -> Response:
         response = (
-            self._client.request(method, url, data=json, headers=headers)
+            self._client.request(method, url, data=json, headers=headers, params=params)
             if isinstance(json, str)
-            else self._client.request(method, url, json=json, headers=headers)
+            else self._client.request(
+                method, url, json=json, headers=headers, params=params
+            )
         )
         try:
             response.raise_for_status()
@@ -122,6 +124,7 @@ def invoke(
         if not is_valid_str_arg(function_name):
             raise ValueError("function_name must a valid string value.")
         headers = self.headers
+        params = QueryParams()
         body = None
         response_type = "text/plain"
         url = f"{self.url}/{function_name}"
@@ -139,15 +142,15 @@ def invoke(
                 if region.value != "any":
                     headers["x-region"] = region.value
                     # Add region as query parameter
-                    url = f"{url}?{urlencode({'forceFunctionRegion': region.value})}"
+                    params = params.set("forceFunctionRegion", region.value)
 
             body = invoke_options.get("body")
             if isinstance(body, str):
                 headers["Content-Type"] = "text/plain"
             elif isinstance(body, dict):
                 headers["Content-Type"] = "application/json"
 
-        response = self._request("POST", url, headers=headers, json=body)
+        response = self._request("POST", url, headers=headers, json=body, params=params)
         is_relay_error = response.headers.get("x-relay-header")
 
         if is_relay_error and is_relay_error == "true":

src/functions/tests/_async/test_function_client.py

@@ -104,7 +104,7 @@ async def test_invoke_with_region(client: AsyncFunctionsClient):
         # Check that x-region header is present
         assert kwargs["headers"]["x-region"] == "us-east-1"
         # Check that the URL contains the forceFunctionRegion query parameter
-        assert "forceFunctionRegion=us-east-1" in args[1]
+        assert kwargs["params"]["forceFunctionRegion"] == "us-east-1"
 
 
 async def test_invoke_with_region_string(client: AsyncFunctionsClient):
@@ -125,7 +125,7 @@ async def test_invoke_with_region_string(client: AsyncFunctionsClient):
         # Check that x-region header is present
         assert kwargs["headers"]["x-region"] == "us-east-1"
         # Check that the URL contains the forceFunctionRegion query parameter
-        assert "forceFunctionRegion=us-east-1" in args[1]
+        assert kwargs["params"]["forceFunctionRegion"] == "us-east-1"
 
 
 async def test_invoke_with_http_error(client: AsyncFunctionsClient):

src/functions/tests/_sync/test_function_client.py

@@ -98,7 +98,7 @@ def test_invoke_with_region(client: SyncFunctionsClient):
         # Check that x-region header is present
         assert kwargs["headers"]["x-region"] == "us-east-1"
         # Check that the URL contains the forceFunctionRegion query parameter
-        assert "forceFunctionRegion=us-east-1" in args[1]
+        assert kwargs["params"]["forceFunctionRegion"] == "us-east-1"
 
 
 def test_invoke_with_region_string(client: SyncFunctionsClient):
@@ -117,7 +117,7 @@ def test_invoke_with_region_string(client: SyncFunctionsClient):
         # Check that x-region header is present
         assert kwargs["headers"]["x-region"] == "us-east-1"
         # Check that the URL contains the forceFunctionRegion query parameter
-        assert "forceFunctionRegion=us-east-1" in args[1]
+        assert kwargs["params"]["forceFunctionRegion"] == "us-east-1"
 
 
 def test_invoke_with_http_error(client: SyncFunctionsClient):