fix: paragraph autospacing calculation (SD-1653)#1877
Merged
harbournick merged 6 commits intomainfrom Jan 30, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90fab31780
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
reviewed
Jan 29, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
Solid cleanup of line spacing normalization. Left a couple of questions inline:
- The autospacing calculation may need the same multiplier→twips conversion as
normalizeLineValue - Wanted to confirm the font-dependent behavior for
exactspacing is intentional
LGTM otherwise - the spec-compliant autospacing override and list handling look good.
packages/layout-engine/pm-adapter/src/attributes/spacing-indent.ts
Outdated
Show resolved
Hide resolved
harbournick
deleted the
luccas/sd-1653-fix-paragraph-autospacing-to-ignore-explicit-values
branch
|
🎉 This PR is included in version 1.11.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.1-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
superdoc-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
# [1.1.0](template-builder-v1.0.0...template-builder-v1.1.0) (2026-02-03) ### Bug Fixes * cli package public ([7dad84d](7dad84d)) * cli skill uses latest ([b74d9ba](b74d9ba)) * **cli:** document -h flag in help text ([020c4a0](020c4a0)) * **cli:** document -h flag in help text ([68fa42f](68fa42f)) * **cli:** move bundled deps to devDependencies ([6a362ed](6a362ed)) * **cli:** remove bundled deps from package.json ([f90d4af](f90d4af)) * console log ([4b64109](4b64109)) * paragraph autospacing calculation (SD-1653) ([#1877](#1877)) ([b7dec3c](b7dec3c)) ### Features * add esign package to monorepo ([#1895](#1895)) ([532e2b5](532e2b5)) * **cli:** add claude code skill ([#1903](#1903)) ([e55ce56](e55ce56)) * new cli app ([#1902](#1902)) ([0c6aeb0](0c6aeb0)) * **template-builder:** add cspNonce support ([#1911](#1911)) ([5b7b34e](5b7b34e))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
harbournick
pushed a commit
that referenced
this pull request
Feb 6, 2026
# [1.11.0](v1.10.0...v1.11.0) (2026-02-06) ### Bug Fixes * cli package public ([7dad84d](7dad84d)) * cli skill uses latest ([b74d9ba](b74d9ba)) * **cli:** document -h flag in help text ([020c4a0](020c4a0)) * **cli:** document -h flag in help text ([68fa42f](68fa42f)) * **cli:** move bundled deps to devDependencies ([6a362ed](6a362ed)) * **cli:** remove bundled deps from package.json ([f90d4af](f90d4af)) * console log ([4b64109](4b64109)) * document dropdown resets ([#1883](#1883)) ([b552d2e](b552d2e)) * lock file ([1edf741](1edf741)) * make Ctrl-a select all content, and fix select all when there are tables in doc ([#1886](#1886)) ([c87c1ab](c87c1ab)) * package lock ([11f47fa](11f47fa)) * paragraph autospacing calculation (SD-1653) ([#1877](#1877)) ([b7dec3c](b7dec3c)) * run color overwrite in applyInlineRunProperties (SD-1585) ([#1885](#1885)) ([6051dd4](6051dd4)) * selection across pages with drag ([#1884](#1884)) ([bb44999](bb44999)) * **super-converter:** handle ECMA-376 percentage strings in table widths (SD-1633) ([#1844](#1844)) ([fb9fd52](fb9fd52)) * **super-converter:** return transparent instead of blue for shapes ([#1854](#1854)) ([6ac29d7](6ac29d7)), closes [#5b9bd5](https://github.com/superdoc-dev/superdoc/issues/5b9bd5) ### Features * add esign package to monorepo ([#1895](#1895)) ([532e2b5](532e2b5)) * add template-builder package to monorepo ([#1888](#1888)) ([0aec624](0aec624)) * **cli:** add claude code skill ([#1903](#1903)) ([e55ce56](e55ce56)) * new cli app ([#1902](#1902)) ([0c6aeb0](0c6aeb0)) * **template-builder:** add cspNonce support ([#1911](#1911)) ([5b7b34e](5b7b34e)) * **vscode-ext:** sync from main ([47c50f7](47c50f7)) * **vscode-ext:** sync from main ([226bcf1](226bcf1)) * **vscode-ext:** sync from main ([eced1f3](eced1f3)) * **vscode-ext:** sync from main ([36b48a6](36b48a6)) * **vscode-ext:** sync from main ([cdc00df](cdc00df))
Collaborator
|
🎉 This PR is included in superdoc v1.11.0 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pm-adapter