feat(super-editor): add pointer event observability#2801
Conversation
superdoc-bot
Bot
added
review: thorough
review: quick
and removed
review: thorough
labels
|
📦 Preview published: npm install superdoc@pr-2801 |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
hey @mattConnHarbour! good call on adding these :)
one small type thing inline.
| pointerUp: [{ editor: Editor; event: PointerEvent }]; | ||
|
|
||
| /** Called on right-click (local only, not broadcast via collaboration) */ | ||
| rightClick: [{ editor: Editor; event: MouseEvent }]; |
There was a problem hiding this comment.
the value passed is a PointerEvent (it comes from the pointer-down handler), but you're typing it as MouseEvent. that hides pointer-only fields like pointerId. the other two events above have it right.
| rightClick: [{ editor: Editor; event: MouseEvent }]; | |
| /** Called on right-click (local only, not broadcast via collaboration) */ | |
| rightClick: [{ editor: Editor; event: PointerEvent }]; |
same fix in EditorConfig.ts:521 for onRightClick.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.3 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.30.0-next.3 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.8.0-next.21 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.3 |
3 participants
No description provided.