Skip to content

fix: rebuild fragment on geometry change#2842

Merged
harbournick merged 2 commits intomainfrom
artem/SD-2446
Apr 22, 2026
Merged

fix: rebuild fragment on geometry change#2842
harbournick merged 2 commits intomainfrom
artem/SD-2446

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented Apr 16, 2026

Linear: SD-2446

@artem-harbour artem-harbour self-assigned this Apr 16, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Apr 16, 2026

SD-2446 BUG: wide margin adjustments can cut off text and make trailing content unclickable

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@artem-harbour artem-harbour marked this pull request as ready for review April 16, 2026 12:57
chittolinag
chittolinag approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@chittolinag chittolinag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved, but left a small comment on the test.

Comment thread packages/layout-engine/painters/dom/src/index.test.ts
@artem-harbour artem-harbour force-pushed the artem/SD-2446 branch 5 times, most recently from d96b2aa to 707477f Compare April 22, 2026 10:02
harbournick
harbournick approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 84b5fbc into main Apr 22, 2026
63 checks passed
@harbournick harbournick deleted the artem/SD-2446 branch April 22, 2026 22:26
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.43

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in vscode-ext v2.3.0-next.45

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in template-builder v1.6.0-next.8

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in esign v2.3.0-next.45

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in superdoc v1.28.0-next.8

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in superdoc-cli v0.8.0-next.8

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 22, 2026

🎉 This PR is included in superdoc-sdk v1.6.0-next.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harbournick harbournick harbournick approved these changes

@chittolinag chittolinag chittolinag approved these changes

Assignees

@artem-harbour artem-harbour

Labels

ready for review released on @next review: thorough

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@artem-harbour @codecov-commenter @harbournick @chittolinag