fix: mirror explicit left/right paragraph alignment for rtl#3235
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e56997752c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
hey @artem-harbour - i pushed a follow-up commit with import-path behavior + pm-adapter unit coverage, and uploaded the fixture to the R2 corpus so layout + visual auto-discover it. i also pushed the matching writer-side tests to #3244.
lgtm once both PRs merge together.
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.81 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.126 |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.124 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.8.0-next.98 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.80 |
|
🎉 This PR is included in superdoc v1.30.0-next.80 The release is available on GitHub release |
3 participants
Linear: SD-3093
Fixes RTL paragraph alignment rendering parity with Word in
pm-adapter.What changed
left/rightare mirrored for RTL paragraphs (w:bidicontext).Why
For RTL documents with explicit
w:jcvalues (notablyw:jc="right"), SuperDoc could render alignment opposite to Word. This patch aligns rendering behavior with OOXML/Word semantics.Scope
Render pipeline only (
layout-engine/pm-adapter), no toolbar/editor command changes.Related: #3244