Fix return none #172
Merged
Fix return none #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnowling-memphis
requested review from
idanasulin2706 and
shohamroditimemphis
as code owners
idanasulin2706
approved these changes
Jun 28, 2023
Contributor
idanasulin2706
left a comment
idanasulin2706
left a comment
There was a problem hiding this comment.
Thanks @rnowling-memphis for another great one
idanasulin2706
added a commit
that referenced
this pull request
Jul 9, 2023
* Update README.md * Fix return none (#172) * Fix case where consumer.fetch() returns None * Add docs * Begin adding documentation * add connid ti destroy prodcuer consumer (#176) * version update --------- Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: RJ Nowling <130711295+rnowling-memphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev>
idanasulin2706
added a commit
that referenced
this pull request
Jul 17, 2023
* Update README.md * Fix return none (#172) * Fix case where consumer.fetch() returns None * Add docs * Begin adding documentation * add connid ti destroy prodcuer consumer (#176) * version update * Fix : no-member error for Exception status_code member (#1) Bug Fix for no-member error for Exception status_code member in which i have fixed the following erros: memphis/producer.py:210:45: E1101: Instance of 'Exception' has no 'status_code' member (no-member) and after fixing that, this error occured on the same line 269:12: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) * Fix doc example syntax for Consumer.fetch() * Update CODEOWNERS (#180) * Update CODEOWNERS * Add examples to docstrings for consumer methods * Added required changes in comsumer.py - removed the first line and blank lines - Used the named parameters * Removed callback parameter * version update --------- Co-authored-by: Yaniv Ben Hemo <70286779+yanivbh1@users.noreply.github.com> Co-authored-by: RJ Nowling <130711295+rnowling-memphis@users.noreply.github.com> Co-authored-by: Shay Bratslavsky <shay@memphis.dev> Co-authored-by: Adarsh jaiswal <its.adarshjaiss@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consumer.fetch() times out, it returns None. Instead, it should return an empty batch (list).