Skip to content

partition ping fix #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023
Merged

partition ping fix #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3def8c7
changed stream name to ping and added validation for the errors
Aug 15, 2023
56fa8f9
resolved pylint
Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions memphis/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,20 +251,21 @@ async def __ping_consumer(self, callback):
await asyncio.sleep(self.ping_consumer_interval_ms / 1000)
station_inner = get_internal_name(self.station_name)
consumer_group = get_internal_name(self.consumer_group)
if self.inner_station_name not in self.connection.partition_consumers_updates_data:
if self.inner_station_name in self.connection.partition_consumers_updates_data:
for p in self.connection.partition_consumers_updates_data[station_inner]["partitions_list"]:
stream_name = f"{station_inner}${str(p)}.final"
stream_name = f"{station_inner}${str(p)}"
await self.connection.broker_connection.consumer_info(
stream_name, consumer_group, timeout=30
)
else:
stream_name = f"{station_inner}.final"
stream_name = station_inner
await self.connection.broker_connection.consumer_info(
stream_name, consumer_group, timeout=30
)

except Exception as e:
callback(MemphisError(str(e)))
if "consumer not found" in str(e) or "stream not found" in str(e):
callback(MemphisError(str(e)))

async def destroy(self):
"""Destroy the consumer."""
Expand Down