chore: added the extra examples from academy to the python readme #221
Conversation
…as well for review"
John-Memphis
requested review from
daniel-davidd,
idanasulin2706,
rnowling-memphis and
shay23b
as code owners
John-Memphis
changed the title
|
@yanivbh1 please review |
README.md
Outdated
|
|
||
| For details on deploying memphis open-source with different types of connections see the [docs](https://docs.memphis.dev/memphis/memphis-broker/concepts/security). | ||
|
|
||
| The default connection type (for cloud) is using a JWT token-based connection. Here is an example of using memphis.connect with a JWT token: |
There was a problem hiding this comment.
@idanasulinmemphis @shay23b not sure I understand this comment. Also, the default connection method is password-based.
There was a problem hiding this comment.
@John-Memphis I dont see any example with account id for connecting with the Cloud
There was a problem hiding this comment.
@yanivbh1 I'll add an example for that.
All of the repos say that the default connection is token based. I've only been using Memphis with open-source and deployed with docker--where password is the default. I was assuming it was a kubernetes thing or a memphis cloud thing that used tokens by default.
If that's not the case I'll go and change that in all of the repos.
| partitions_number=1, # defaults to 1 | ||
| dls_station="<station-name>" # defaults to "" (no DLS station) - If selected DLS events will be sent to selected station as well | ||
| ) | ||
| **A station will be automatically created for the user when a consumer or producer is used if no stations with the given station name exist.**<br><br> |
There was a problem hiding this comment.
@John-Memphis , please add a phrase on what a station is
… sounds good, and addressed the changes in the PR that Yaniv made"
|
Synced with master, addressed comments from @yanivbh1 and changed some of the sentences throughout for a better reading experience. This readme update should be ready. |
|
@John-Memphis for me that looks ok, @yanivbh1 please take a look as well |
|
@idanasulinmemphis looks great to me |
Search for "TO:DO" (no quotes) in the file. There's a part that needs to be double checked for clarity about what the words actually mean.