Updated max reconnect to retry forever #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbazen
requested review from
daniel-davidd,
idanasulin2706 and
shay23b
as code owners
idanasulin2706
requested changes
Dec 7, 2023
README.md
Outdated
| port=<port>, # defaults to 6666 | ||
| reconnect=True, # defaults to True | ||
| max_reconnect=10, # defaults to 10 | ||
| max_reconnect=10, # defaults to -1 |
Contributor
There was a problem hiding this comment.
Add explanation that -1 is infinitely
memphis/memphis.py
Outdated
| port (int, optional): port. Defaults to 6666. | ||
| reconnect (bool, optional): whether to do reconnect while connection is lost. Defaults to True. | ||
| max_reconnect (int, optional): The reconnect attempt. Defaults to 10. | ||
| max_reconnect (int, optional): The reconnect attempt. |
Contributor
There was a problem hiding this comment.
Add explanation that -1 is infinitely and mention that -1 is the default
idanasulin2706
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.