NATS SDK compatibility #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incoming NATS connections will use this user
…n in UI)" This reverts commit bef727f.
modify GetMessages and GetMessageDetails to gracefully allow non-memphis-header messages
| // NATS SDK, means we extract username from the token field | ||
| splittedToken := strings.Split(client.opts.Token, connectItemSep) | ||
| if len(splittedToken) != 2 { | ||
| client.Warnf("handleConnectMessage: missing username or connectionId") |
There was a problem hiding this comment.
connection id -> token
| splittedToken := strings.Split(client.opts.Token, connectItemSep) | ||
| if len(splittedToken) != 2 { | ||
| client.Warnf("handleConnectMessage: missing username or connectionId") | ||
| return errors.New("missing username or connectionId") |
| } | ||
| username := splittedToken[0] | ||
| client.memphisInfo = memphisClientInfo{username: username, isNative: false} | ||
| return nil |
There was a problem hiding this comment.
this function should validate the user validations part + send proper analytics (new event user-connect-nats-sdk)
| func (js *jetStream) apiDispatch(sub *subscription, c *client, acc *Account, subject, reply string, rmsg []byte) { | ||
| // No lock needed, those are immutable. | ||
| s, rr := js.srv, js.apiSubs.Match(subject) | ||
| wrappedSubject := memphisFindJSAPIWrapperSubject(c, subject) |
There was a problem hiding this comment.
I need you to explain it to me
server/memphis_helper.go
Outdated
|
|
||
| msgs, err := s.memphisGetMsgs(stationName.Intern()+".final", | ||
| stationName.Intern(), | ||
| msgs, err := s.memphisGetMsgs(stationName.Intern(), |
There was a problem hiding this comment.
Why have you deleted it?
There was a problem hiding this comment.
Apparently, there was no use of that parameter inside the function, just cleaned it.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "files": { | |||
There was a problem hiding this comment.
remove all static files from the PR
…or non-native sdk clients
OrMemphis
force-pushed
the
nats-sdk-compatiblity
branch
from
83c232d to
762585d
Compare
server/memphis_handlers_stations.go
Outdated
| removeFunc := nonNativeRemoveStreamFunc | ||
| if removeFunc == nil { | ||
| if !station.IsNative { | ||
| s.Fatalf("non native station uses native remove stream function") |
There was a problem hiding this comment.
please change to error and return the user an error
| } | ||
| analyticsParams := []analytics.EventParam{param} | ||
| analytics.SendEventWithParams(user.Username, analyticsParams, "user-connect-sdk") | ||
| analytics.SendEventWithParams(username, analyticsParams, "user-connect-sdk") |
There was a problem hiding this comment.
please send new event user-connect-nats-sdk when this is non native connection
plain error on nats-sdk usage in a native memphis station
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.