Skip to content

fix internal cg name to dls subj #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2023
Merged

fix internal cg name to dls subj #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/background_tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ func ackPoisonMsgV0(msgId string, cgName string) error {
uid := serv.memphis.nuid.Next()
durableName := "$memphis_fetch_dls_consumer_" + uid
amount := uint64(1)
filter := GetDlsSubject("poison", sn.Intern(), msgId, cgName)
internalCgName := replaceDelimiters(cgName)
filter := GetDlsSubject("poison", sn.Intern(), msgId, internalCgName)
timeout := 30 * time.Second
msgs, err := serv.memphisGetMessagesByFilter(streamName, filter, 0, amount, timeout)

Expand Down
7 changes: 4 additions & 3 deletions server/memphis_handlers_dls_messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ func (s *Server) handleNewPoisonMessage(msg []byte) {
Message: messagePayload,
CreationDate: time.Now(),
}
poisonSubjectName := GetDlsSubject("poison", stationName.Intern(), id, cgName)
internalCgName := replaceDelimiters(cgName)
poisonSubjectName := GetDlsSubject("poison", stationName.Intern(), id, internalCgName)
msgToSend, err := json.Marshal(pmMessage)
if err != nil {
serv.Errorf("handleNewPoisonMessage: Error while getting notified about a poison message: " + err.Error())
Expand Down Expand Up @@ -674,8 +675,8 @@ func GetTotalPoisonMsgsByCg(stationName, cgName string) (int, error) {
if streamInfo.State.FirstSeq > 0 {
startSeq = streamInfo.State.FirstSeq
}

filter := GetDlsSubject("poison", sn.Intern(), "*", cgName)
internalCgName := replaceDelimiters(cgName)
filter := GetDlsSubject("poison", sn.Intern(), "*", internalCgName)
msgs, err := serv.memphisGetMessagesByFilter(streamName, filter, startSeq, amount, timeout)
if err != nil {
return 0, err
Expand Down