Skip to content

Conversation

@sattvikc
Copy link
Collaborator

@sattvikc sattvikc commented Aug 8, 2022

Summary of change

Ref - supertokens/supertokens-node#367
This issue did not exist for golang, added test to verify the same.

Related issues

Test Plan

Added test

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

@sattvikc sattvikc self-assigned this Aug 8, 2022
@sattvikc sattvikc requested a review from rishabhpoddar August 8, 2022 06:11
@rishabhpoddar rishabhpoddar merged commit b169960 into 0.8 Aug 8, 2022
@rishabhpoddar rishabhpoddar deleted the session-container-override-test branch August 8, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants