Skip to content

Conversation

@nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Apr 3, 2023

Summary of change

  • renames all variable uses of sessionData to sessionDataInDatabase
  • renames GetSessionData and GetSessionDataWithContext to GetSessionDataInDatabase*
  • renames UpdateSessionData and UpdateSessionDataWithContext to UpdateSessionDataInDatabase*

Related issues

Test Plan

Updated existing tests to account for this

Documentation changes

WIP

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • ...

@nkshah2 nkshah2 requested a review from porcellus April 3, 2023 07:16
@nkshah2 nkshah2 changed the title refactor: Rename sessionData and its functions refactor: Rename sessionData and its functions (JWT Rework #1) Apr 3, 2023
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@porcellus porcellus merged commit cdae04d into feat/jwt-rework Apr 5, 2023
@porcellus porcellus deleted the jwt-rework/rename-sessiondata branch April 5, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants