refactors all code except for session recipe #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HandleAPIRequest func(id string, req *http.Request, w http.ResponseWriter, path NormalisedURLPath, method string) error | ||
| GetAllCORSHeaders func() []string | ||
| GetAPIsHandled func() []APIHandled | ||
| GetAPIsHandled func() (*[]APIHandled, error) |
There was a problem hiding this comment.
no need of pointer. slice can be nil.
| func MakeRecipeModule(recipeId string, appInfo NormalisedAppinfo, | ||
| HandleAPIRequest func(id string, req *http.Request, w http.ResponseWriter, path NormalisedURLPath, method string) error, | ||
| GetAllCORSHeaders func() []string, | ||
| GetAPIsHandled func() (*[]APIHandled, error)) RecipeModule { |
There was a problem hiding this comment.
no need of pointer. slice can be nil.
7 tasks
nkshah2
added a commit
that referenced
this pull request
Apr 14, 2023
…n-functions refactor: Remove deprecated session functions (JWT Rework #7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Piyushhbhutoria I have made several changes:
interfaceand replaced them withstructinstanceinside structs to simulate singleton behaviorotherHandlervar to APIOption (not sure if this is the right thing to do, but it's what's done in node)MakeStructfunction pattern to create new structs.I can get on a call to discuss all of the above. There are also a few TODOs I have added that I would like to discuss with you.
NOTE: There will be compile time errors in the session recipe due to some of the changes to recipeModule etc..