Skip to content

feat: add iss into access tokens + update/fix tests #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: add iss into access tokens + update/fix tests #546

merged 1 commit into from
Apr 24, 2023

Conversation

@porcellus
Copy link
Collaborator

Summary of change

  • Adding iss claim during createNewSession
  • Updated/fixed tests

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Item1
  • Item2

rishabhpoddar
rishabhpoddar suggested changes Apr 24, 2023
View reviewed changes
@rishabhpoddar rishabhpoddar merged commit 294edbf into feat/access_token_to_jwt_base Apr 24, 2023
@rishabhpoddar rishabhpoddar deleted the feat/iss_in_access_tokens branch April 24, 2023 10:15
@nkshah2 nkshah2 mentioned this pull request Apr 26, 2023
Merged
7 tasks
rishabhpoddar added a commit that referenced this pull request May 4, 2023
@porcellus @rishabhpoddar
feat: access token to jwt base (#531)
177f43e 
* feat!: rename sessionData handling functions (#519)

* feat\!: rename sessionData handling functions

* feat: rename sessionData in param and return types to sessionDataInDatabase

* feat: access token to jwt (#512)

* feat(access token to jwt): initial changes

* feat(access_token_to_jwt): initial implementation

* refactor: removed unused code/fixed names

* test: add/fix tests

* fix: implement review comments

* chore: deprecate jwt config option

* feat: implement review comments

* test: update&expand tests

* test: expand testing + changelog

* feat: re-add openId overrides into session config + moved protected prop filtering

* chore: add migration guide to changelog

* fix: delete protected props before merging claim updates during assertClaims

* fix: more consistent payload handling

* fix: update tests and add separate handling for v2 tokens

* feat: add new functions based on session ADR 0030 (#520)

* feat(access token to jwt): initial changes

* feat(access_token_to_jwt): initial implementation

* refactor: removed unused code/fixed names

* test: add/fix tests

* fix: implement review comments

* chore: deprecate jwt config option

* feat: add new functions based on session ADR 0030

* chore: update CHANGELOG

* feat: implement review comments

* test: update&expand tests

* test: expand testing + changelog

* feat: re-add openId overrides into session config + moved protected prop filtering

* chore: add migration guide to changelog

* fix: delete protected props before merging claim updates during assertClaims

* feat: add tests + small fixes/exports

* fix: more consistent payload handling

* refactor: implement review comments

* feat: make the invalid claims response and the return value of getSessionWithoutModifyingResponse match

* feat: single override for session handling funcs with&without request

* feat: remove useDynamicAccessTokenSigningKey from createNewSession and check it in verify

* feat: review comments

* refactor: renamed TOKEN_VALIDATION_ERROR to UNAUTHORISED

* chore: update changelog

* refactor: self-review fixes

* feat: make it easy to both throw or build response if claim validation failed

* fix: update createJWT in openId and session recipes + CDI version (#538)

* refactor: minor cleanup +fixes from other SDKs for access token to jwt (#542)

* fix: update createJWT in openId and session recipes + CDI version

* docs: add comment to explain the combinedJWKS func

* fix: fix migration guide in changelog

* refactor: introduce constant for 100 years + fix comment

* feat: changed withoutreqres methods to throw instead of returning status + test fixes

* feat: rename accessTokenPayload to customClaimsInAccessTokenPayload in session info

* Update CHANGELOG.md

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>

* feat: add iss into access tokens + update/fix tests (#546)

* fix: type fixes + small test fixes/extension (#547)

* feat: add iss into access tokens + update/fix tests

* test: further test fixes

* fix: fix types of both getSession versions

* refactor: smaller cleanup/minor fixes (#556)

* feat: add iss into access tokens + update/fix tests

* test: further test fixes

* fix: fix types of both getSession versions

* chore: fix CDI version in changelog

* chore: fix typo in changelog

* fix: fix access token payload for legacy tokens + minor consistency fixes

* docs: update comment to match new interface

* chore: update changelog

* fix: add missing return

* refactor: move v2 specific code to the appropriate branch

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
rishabhpoddar added a commit that referenced this pull request Jun 30, 2023
@porcellus @rishabhpoddar
refactor: edge function compatibility (#599)
1f21793 
* feat!: rename sessionData handling functions (#519)

* feat\!: rename sessionData handling functions

* feat: rename sessionData in param and return types to sessionDataInDatabase

* feat: access token to jwt (#512)

* feat(access token to jwt): initial changes

* feat(access_token_to_jwt): initial implementation

* refactor: removed unused code/fixed names

* test: add/fix tests

* fix: implement review comments

* chore: deprecate jwt config option

* feat: implement review comments

* test: update&expand tests

* test: expand testing + changelog

* feat: re-add openId overrides into session config + moved protected prop filtering

* chore: add migration guide to changelog

* fix: delete protected props before merging claim updates during assertClaims

* fix: more consistent payload handling

* fix: update tests and add separate handling for v2 tokens

* feat: add new functions based on session ADR 0030 (#520)

* feat(access token to jwt): initial changes

* feat(access_token_to_jwt): initial implementation

* refactor: removed unused code/fixed names

* test: add/fix tests

* fix: implement review comments

* chore: deprecate jwt config option

* feat: add new functions based on session ADR 0030

* chore: update CHANGELOG

* feat: implement review comments

* test: update&expand tests

* test: expand testing + changelog

* feat: re-add openId overrides into session config + moved protected prop filtering

* chore: add migration guide to changelog

* fix: delete protected props before merging claim updates during assertClaims

* feat: add tests + small fixes/exports

* fix: more consistent payload handling

* refactor: implement review comments

* feat: make the invalid claims response and the return value of getSessionWithoutModifyingResponse match

* feat: single override for session handling funcs with&without request

* feat: remove useDynamicAccessTokenSigningKey from createNewSession and check it in verify

* feat: review comments

* refactor: renamed TOKEN_VALIDATION_ERROR to UNAUTHORISED

* chore: update changelog

* refactor: self-review fixes

* feat: make it easy to both throw or build response if claim validation failed

* fix: update createJWT in openId and session recipes + CDI version (#538)

* refactor: minor cleanup +fixes from other SDKs for access token to jwt (#542)

* fix: update createJWT in openId and session recipes + CDI version

* docs: add comment to explain the combinedJWKS func

* fix: fix migration guide in changelog

* refactor: introduce constant for 100 years + fix comment

* feat: changed withoutreqres methods to throw instead of returning status + test fixes

* feat: rename accessTokenPayload to customClaimsInAccessTokenPayload in session info

* Update CHANGELOG.md

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>

* feat: add iss into access tokens + update/fix tests (#546)

* fix: type fixes + small test fixes/extension (#547)

* feat: add iss into access tokens + update/fix tests

* test: further test fixes

* fix: fix types of both getSession versions

* removes import from url

* tries to use node fetch

* tries to use node fetch

* refactor: replaced node-fetch and axios with cross-fetch

* refactor: remove verify-apple-id-token, jsonwebtoken, jwks-rsa deps

* build: remove unused deps

* refactor: replace co-body and body-parser deps in lib code

* fix: fix migration to fetch

* fix: fix serialization issue + tests

* test: revert merge error

* refactor: test fixes

* refactor: self-review fixes

* fix: fix minor issues from e2e tests

* fix: fix apple client secret generation

* refactor: fix review comments

---------

Co-authored-by: Rishabh Poddar <rishabh.poddar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@porcellus @rishabhpoddar