fix: updates function signitures #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action function signitures
rishabhpoddar
approved these changes
Apr 20, 2022
Comment on lines
27
to
28
| // associate a userId with a role that exist | ||
| boolean addRoleToUser(String userId, String role) |
rishabhpoddar
pushed a commit
that referenced
this pull request
May 6, 2022
* adds recipe interface * feat(userroles): fixs comments * feat(userroles): fixs * feat(userroles): fixs comment * adds feedback * fixs * fixs * removes version changes * removes unnecessary function * feedback changes * fixs function signiture * implements feedback * updates deleteRole return type * removes duplicateRoleException * renames createNewRole_Transaction, removes DuplicateRolePermissionMapping * removes DuplicateRolePermissionMappingException * renames addPermissionToRole function (#35) * fix: updates function signitures (#36) * fix: updates addRoleToUser and createNewRoleOrDoNothingIfExists_Transaction function signitures * changes to boolean * undos change * fixs typo * updates build.gradle (#37) * chore: updates changelog (#38) * updates CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Updating the
createNewRoleOrDoNothingIfExists_Transactionto return abooleanso we know if any rows are updated when creating a role or adding a role to a user. This change is due to the discussion mentionedRelated issues
Checklist for important updates
[ ] Changelog has been updated[ ] Changes to the version if neededInbuild.gradle[ ] Issue this PR against the latest non released version branch.To know which one it is, run find the latest released tag (git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.If no such branch exists, then create one from the latest released branch.Remaining TODOs for this PR