fix: updates plugin interface functions #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
approved these changes
Apr 21, 2022
rishabhpoddar
pushed a commit
that referenced
this pull request
May 6, 2022
* feat(user-roles): adds some user role queries and functions * adds TODOs, removes unnecessary comment * query fixs * removes comment * fixs * adds getRoles function * fix: renames addRoleToPermission function (#39) * feat: adds functions for setting a role for a user and retriving user roles (#40) * adds functions for setting a role for a user and retriving user roles * fixs * fix: updates plugin interface functions (#42) * feat: adds doesRoleExist_transaction and deleteUserRole_transaction (#41) * feat: adds doesRoleExist_transaction and deleteUserRole_transaction * updates doesRoleExist_Transaction with FOR UPDATE * feat: adds getUsersForRoleAPI functions (#43) * feat: adds RemovePermissionsFromRoleAPI (#44) * feat: adds getRolesForPermissionAPI function (#45) * feat: adds deleteAllRolesForUser functions (#46) * chore: updates (#47) * updates * fixs * updates CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Updates plugin interface functions due to the discussion here
Related issues
Test Plan
Run core tests
Documentation changes
Checklist for important updates
Changelog has been updatedpluginInterfaceSupported.jsonfile has been updated (if needed)Changes to the version if neededInbuild.gradleIf there are new dependencies that have been added inbuild.gradle, please make sure to add them inimplementationDependencies.json.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.~~If no such branch exists, then create one from the latest released branch.Remaining TODOs for this PR