Skip to content

Commit 0ffb12c

Browse files
committed
[HIP] Mark kernels with uniform-work-group-size=true
Differential Revision: https://reviews.llvm.org/D76076
1 parent 2e77f0c commit 0ffb12c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

clang/lib/CodeGen/TargetInfo.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8091,6 +8091,10 @@ void AMDGPUTargetCodeGenInfo::setTargetAttributes(
80918091
(M.getTriple().getOS() == llvm::Triple::AMDHSA))
80928092
F->addFnAttr("amdgpu-implicitarg-num-bytes", "56");
80938093

8094+
if (IsHIPKernel)
8095+
F->addFnAttr("uniform-work-group-size", "true");
8096+
8097+
80948098
const auto *FlatWGS = FD->getAttr<AMDGPUFlatWorkGroupSizeAttr>();
80958099
if (ReqdWGS || FlatWGS) {
80968100
unsigned Min = 0;

clang/test/CodeGenCUDA/amdgpu-kernel-attrs.cu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ __global__ void num_vgpr_64() {
3939
// NAMD-NOT: "amdgpu-num-vgpr"
4040
// NAMD-NOT: "amdgpu-num-sgpr"
4141

42-
// DEFAULT-DAG: attributes [[FLAT_WORK_GROUP_SIZE_DEFAULT]] = {{.*}}"amdgpu-flat-work-group-size"="1,256"
42+
// DEFAULT-DAG: attributes [[FLAT_WORK_GROUP_SIZE_DEFAULT]] = {{.*}}"amdgpu-flat-work-group-size"="1,256"{{.*}}"uniform-work-group-size"="true"
4343
// MAX1024-DAG: attributes [[FLAT_WORK_GROUP_SIZE_DEFAULT]] = {{.*}}"amdgpu-flat-work-group-size"="1,1024"
4444
// CHECK-DAG: attributes [[FLAT_WORK_GROUP_SIZE_32_64]] = {{.*}}"amdgpu-flat-work-group-size"="32,64"
4545
// CHECK-DAG: attributes [[WAVES_PER_EU_2]] = {{.*}}"amdgpu-waves-per-eu"="2"

0 commit comments

Comments
 (0)