Skip to content

Commit 6593360

Browse files
committed
AMDGPU: Fix consistently backwards logic for default denormal mode
I forgot to squash this into c9d65a4
1 parent 9b31e59 commit 6593360

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

clang/lib/Driver/ToolChains/AMDGPU.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,10 @@ bool AMDGPUToolChain::getDefaultDenormsAreZeroForTarget(
109109

110110
// Default to enabling f32 denormals by default on subtargets where fma is
111111
// fast with denormals
112-
const bool DefaultDenormsAreZeroForTarget =
112+
const bool BothDenormAndFMAFast =
113113
(ArchAttr & llvm::AMDGPU::FEATURE_FAST_FMA_F32) &&
114114
(ArchAttr & llvm::AMDGPU::FEATURE_FAST_DENORMAL_F32);
115-
116-
return DefaultDenormsAreZeroForTarget;
115+
return !BothDenormAndFMAFast;
117116
}
118117

119118
llvm::DenormalMode AMDGPUToolChain::getDefaultDenormalModeForType(
@@ -137,7 +136,7 @@ llvm::DenormalMode AMDGPUToolChain::getDefaultDenormalModeForType(
137136
// TODO: There are way too many flags that change this. Do we need to check
138137
// them all?
139138
bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) ||
140-
!getDefaultDenormsAreZeroForTarget(Kind);
139+
getDefaultDenormsAreZeroForTarget(Kind);
141140
// Outputs are flushed to zero, preserving sign
142141
return DAZ ? llvm::DenormalMode::getPreserveSign() :
143142
llvm::DenormalMode::getIEEE();

0 commit comments

Comments
 (0)