Ensure that attributes set during contribute_to_class are copied.
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTruck
force-pushed
the
copy-attname-etc
branch
from
1da3c04 to
c637f45
Compare
The `PydanticSchemaField` is currently incompatible with the popular `django-simple-history` library as not all attributes defined on the field are copied when `copy` is invoked. This change ensures that any missing attributes are also set on the copied instance.
TomTruck
force-pushed
the
copy-attname-etc
branch
from
0346c4a to
d6a512b
Compare
Owner
|
Hi @TomTruck, I really appreciate your help! I put a small stylistic changes on this branch and will be merging it once all checks are passed. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first all all, thanks for creating
django-pydantic-fieldit's proving incredibly useful for me and my team.We've encountered a minor issue which we've worked around on our project and whose solution I though I'd share.
The
PydanticSchemaFieldis currently incompatible with the populardjango-simple-historylibrary as not all attributes defined on the field are copied whencopyis invoked.This change ensures that any missing attributes are also set on the copied instance.
I'm not sure if this is the best way to do this so any feedback would be gladly received.
Many thanks,
Tom