Preserve kwargs for json.dumps() #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantics'
json()method forwards all unused kwargs e.g.indenttojson.dumps(). However,base.extract_export_kwargs()only considers arguments for pydantic and drops others.My usecase is having the data loaded from a Django
JSONFieldnicely indented when shown in a form; so at least passing onindentwould be useful for me.The suggested PR allows the kwargs used to "format" the output of
json.dumps():indent,separatorsandsort_keysPlease let me know if I missed a way to do that without the suggested change or any other comments!